-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catppuccin-kvantum: unstable-2022-07-04 -> 0-unstable-2024-10-10 #348071
base: master
Are you sure you want to change the base?
Conversation
Also removes `with lib;`.
with lib;
, update packageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one moment
runHook postInstall | ||
''; | ||
|
||
meta = with lib; { | ||
passthru.updateScript = unstableGitUpdater { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passthru.updateScript = unstableGitUpdater { }; | |
passthru.updateScript = unstableGitUpdater { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one
Also, rename PR to catppuccin-kvantum: unstable-2022-07-04 -> 0-unstable-2024-10-10
rev = "d1e174c85311de9715aefc1eba4b8efd6b2730fc"; | ||
sha256 = "sha256-IrHo8pnR3u90bq12m7FEXucUF79+iub3I9vgH5h86Lk="; | ||
rev = "bdaa531318d5756cea5674a750a99134dad0bbbc"; | ||
sha256 = "sha256-O85y8Gg0l+xQP1eQi9GizuKfLEGePZ3wPdBNR+0V4ZQ="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sha256 = "sha256-O85y8Gg0l+xQP1eQi9GizuKfLEGePZ3wPdBNR+0V4ZQ="; | |
hash = "sha256-O85y8Gg0l+xQP1eQi9GizuKfLEGePZ3wPdBNR+0V4ZQ="; |
Also removes
with lib;
.The package hasn't been updated for 2 years. There was also a commit recently, that fixed legibility issues with highlighted entries, for example in Dolphin.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.