Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump and fix nextjs-ollama-llm-ui #347856

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Bump and fix nextjs-ollama-llm-ui #347856

merged 2 commits into from
Oct 12, 2024
+8 −905

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Oct 11, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@womfoo womfoo mentioned this pull request Oct 11, 2024
Closed
@ofborg ofborg bot requested a review from malteneuss October 11, 2024 08:39
@mschwaig
Copy link
Member

Thanks for doing this!

I tested this on my machine. It works and fixes #344316.

LGTM

malteneuss
malteneuss approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@malteneuss malteneuss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@womfoo @mschwaig Many thanks for updating and reviewing this.

LGTM

@malteneuss
Copy link
Contributor

@drupol Could you merge it or give us a hint if something's missing?

@drupol drupol merged commit afd96ba into NixOS:master Oct 12, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwaig mschwaig mschwaig approved these changes

@malteneuss malteneuss malteneuss approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/nextjs-ollama-llm-ui: Failed to write image to cache ... Error: ENOENT: no such file or directory
5 participants
@womfoo @mschwaig @malteneuss @drupol @wegank