Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PR merge check for CI #347786

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Improve PR merge check for CI #347786

merged 3 commits into from
Oct 12, 2024
+126 −39

Commits on Oct 12, 2024

  1. workflows/nixpkgs-vet: Make merge check script reusable 

    This is useful for other workflows as well. Originally I thought it
couldn't be put in the repo, but it can (just needs another checkout)
    @infinisil
    infinisil committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    7f9d297 View commit details
    Browse the repository at this point in the history

  2. ci/get-merge-commit.sh: Exit for non-open PRs 

    If PRs aren't open (either merged or closed), GitHub never computes
whether the PR is mergeable, so we'd wait forever, which has been
happening:
https://github.com/NixOS/nixpkgs/actions/runs/11279197077/job/31369348101#step:2:59
    @infinisil
    infinisil committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    048f4aa View commit details
    Browse the repository at this point in the history

  3. ci/get-merge-commit.sh: Add documentation 

    And distinguish exit codes
    @infinisil
    infinisil committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    e6a8855 View commit details
    Browse the repository at this point in the history