{tor,mullvad}-browser: 13.5.7 -> 14.0a9 #347698
Draft
+30
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I currently get a segfault when trying to run the browsers. In Oct 10 11:03:44 home-pc systemd-coredump[68167]: [🡕] Process 64009 (firefox) of user 1000 dumped core.
Module libgcc_s.so.1 without build-id.
Module libstdc++.so.6 without build-id.
Stack trace of thread 64009:
#0 0x00000000001b41c0 n/a (n/a + 0x0)
ELF object binary architecture: AMD x86-64
Oct 10 11:03:44 home-pc systemd[1]: [email protected]: Deactivated successfully.and (gdb) bt
#0 0x00000000001b41c0 in ?? ()
#1 0x00007efd08f7726e in call_init () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#2 0x00007efd08f7736c in _dl_init () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#3 0x00007efd08f73586 in _dl_catch_exception () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#4 0x00007efd08f7dffe in dl_open_worker () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#5 0x00007efd08f734f1 in _dl_catch_exception () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#6 0x00007efd08f7e38c in _dl_open () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#7 0x00007efd08a704dc in dlopen_doit () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/libc.so.6
#8 0x00007efd08f734f1 in _dl_catch_exception () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#9 0x00007efd08f73623 in _dl_catch_error () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/ld-linux-x86-64.so.2
#10 0x00007efd08a6ff57 in _dlerror_run () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/libc.so.6
#11 0x00007efd08a705b1 in dlopen@GLIBC_2.2.5 () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/libc.so.6
#12 0x0000559a96dca1f2 in ?? ()
#13 0x0000559a96dc90a1 in ?? ()
#14 0x0000559a96dc8c8b in ?? ()
#15 0x00007efd08a0e14e in __libc_start_call_main () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/libc.so.6
#16 0x00007efd08a0e209 in __libc_start_main_impl () from /nix/store/3dyw8dzj9ab4m8hv5dpyx7zii8d0w6fi-glibc-2.39-52/lib/libc.so.6
#17 0x0000559a96dc8a0a in _start ()Some context: I'm running stable NixOS 24.05 with GNOME on Wayland. |
|
@panicgh could you give this a test and see if you also get the same segfault? Also, the stable release is scheduled for next Tuesday: It would be good if we can manage to fix this issue until then. |
felschr
force-pushed
the
tor-browser-updates
branch
from
eaacf7a
to
5f0a0d3
Compare
|
While looking at the # Firefox uses "relrhack" to manually process relocations from a fixed offset
patchelfFlags = [ "--no-clobber-old-sections" ];And it turns out that fixes the segfault for us, too! More info about the original fix for There is still a segfault in Tor itself, but I'm working on a fix and will push another update soon. |
felschr
force-pushed
the
tor-browser-updates
branch
from
5f0a0d3
to
be0ee73
Compare
…ix segfault Also switches from manual patchelf usage to autoPatchelf to make this fix work for all binaries. Fixups for obfs & snowflake were removed, as they are no longer required.
felschr
force-pushed
the
tor-browser-updates
branch
from
be0ee73
to
613e720
Compare
|
All segfaults should be fixed now. Basic functionality seems to be all good. Also tested Tor bridges and video playback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for upcoming Tor Browser & Mullvad Browser 14.0 release.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.