zed-editor: rename zed binary to zeditor, change pname to zed-editor #344193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are like three different packages with zed
JohnRTitor
force-pushed
the
fix-zed-editor-binary
branch
from
622a0c0 to
cd9cf36
Compare
GaetanLepage
approved these changes
Sep 24, 2024
At least three packages provide a "zed" binary including `zfs`, `spicedb-zed`, and `zed` binary which can lead to conflicts. Renaming the `cli` binary to `zeditor` is even recommmeded in zed-editor official packaging instructions. https://github.com/zed-industries/zed/blob/main/docs/src/development/linux.md#other-things-to-note Signed-off-by: John Titor <[email protected]>
JohnRTitor
force-pushed
the
fix-zed-editor-binary
branch
from
cd9cf36 to
a28f1df
Compare
SigmaSquadron
approved these changes
Sep 24, 2024
SigmaSquadron
added
the
12.approvals: 2
|
NotAShelf
approved these changes
Sep 24, 2024
SigmaSquadron
added
12.approvals: 3+
jansol
approved these changes
Sep 24, 2024
SigmaSquadron
added
the
12.approved-by: package-maintainer
Sweet, didn't know you could specify multiple systems in nixpkgs-review. Anyways thanks for the reviews, I do not think we need release notes for this breaking change, we don't even have zed-editor in 24.05. |
It's a WIP: Mic92/nixpkgs-review#419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
At least three packages provide a "zed" binary including
zfs,spicedb-zed, andzedbinary which can lead to conflicts.Renaming the
clibinary tozeditoris even recommmeded in zed-editor official packaging instructions.https://github.com/zed-industries/zed/blob/main/docs/src/development/linux.md#other-things-to-note
Even arch uses
zeditor.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.