-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luaPackages/vimPlugins: update on 2024-09-16 #342196
Conversation
Result of 25 packages marked as broken and skipped:
10 packages failed to build:
379 packages built:
|
Result of 25 packages marked as broken and skipped:
383 packages built:
|
Result of 24 packages marked as broken and skipped:
4 packages failed to build:
370 packages built:
|
@PerchunPak what was the plenary regression you tested before? |
🤔 what's the build output of |
I get local failures from tests, @GaetanLepage and hydra don't seem to get them #341146 (comment) |
As it's Darwin, could it be related to sandboxing in your nix config (see the issue template check list)? |
Yeah, darwin sandbox support is terrible... I can't enable it in my config due to serialization errors and nixpkgs-review doesn't allow sandbox command on darwin. |
Result of 30 packages marked as broken and skipped:
376 packages built:
|
|
Result of 29 packages marked as broken and skipped:
7 packages failed to build:
356 packages built:
|
Result of 29 packages marked as broken and skipped:
16 packages failed to build:
347 packages built:
|
Tests were failing on plenary, if they run simultaneously. I added |
Result of 29 packages marked as broken and skipped:
363 packages built:
|
Result of 28 packages marked as broken and skipped:
374 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, PR name should be luaPackages, vimPlugins: update on 2024-09-16
, but it is just a nitpick
Overall, if nixpkgs-review doesn't show any fails, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nixpkgs-review
passes, LGTM
Result of 28 packages marked as broken and skipped:
374 packages built:
|
Result of 28 packages marked as broken and skipped:
5 packages failed to build:
356 packages built:
|
We still have some failures on darwin unfortunately. Logs (
|
How about we disable checks for |
Sure, good idea. |
Result of 22 packages marked as broken and skipped:
374 packages built:
|
Result of 21 packages marked as broken and skipped:
374 packages built:
|
Failures I saw were due to already broken dependencies on master. Result of 21 packages marked as broken and skipped:
9 packages failed to build:
365 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice effort @khaneliman !
This PR renamed render-markdown-nvim to render-markdown because the script was run before #340286 was merged. Shuold I fix it with a PR? Or you will run the script soon? |
Yes indeed, I am working on it in #343557. |
Description of changes
Updating both the luaPackages and the vimPlugins together so they can stay in sync.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.