docs: improve go builder comments in module.nix
#341561
Open
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabyx
requested review from
kalbasit,
katexochen,
Mic92 and
zowoq
as code owners
gabyx
force-pushed
the
docs/improve-go-builder
branch
from
ea39d81
to
837a68d
Compare
gabyx
force-pushed
the
docs/improve-go-builder
branch
from
837a68d
to
ba2b918
Compare
kalbasit
requested changes
Sep 14, 2024
Co-authored-by: Wael Nasreddine <[email protected]>
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
2.status: merge conflict
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Only documentation changes:
Some simple typos and comment fixups in the Go build-support function
module.nix.Why: Make it better understandable also for others working on this.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.