Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silicon: patch Cargo.lock for Rust 1.80 #337499

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

GoldsteinE
Copy link
Contributor

@GoldsteinE GoldsteinE commented Aug 26, 2024

See: #332957

Description of changes

Updates time dependency of silicon.

As the project doesn’t seem very active, patch it on our side until we have an upstream solution. Upstream issue: Aloxaf/silicon#255

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (in CI)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GoldsteinE
Copy link
Contributor Author

cc @evanjs @0x4A6F as maintainers

Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also for not using some keyword for closing the overall tracking issue. ❤️

@0x4A6F 0x4A6F merged commit acb4534 into NixOS:master Aug 26, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants