Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqld: 0.17.2 -> 0.24.18 #336887

Merged
merged 1 commit into from
Aug 24, 2024
Merged

sqld: 0.17.2 -> 0.24.18 #336887

merged 1 commit into from
Aug 24, 2024

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Aug 23, 2024

Description of changes

Following up after #290473

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rawkode rawkode requested a review from dit7ya August 23, 2024 23:13
@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

I don't think this error is related to my change.

cc @alyssais who referenced this is kind of important due to Rust updates in staging.

@alyssais
Copy link
Member

Please rebase on latest master to fix CI.

pkgs/servers/sql/sqld/default.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/sqld/default.nix Show resolved Hide resolved
@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

@alyssais Hopefully this resolves the issues

@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

Oh, and thank you very much for your help!

@alyssais
Copy link
Member

I'm afraid you'll have to rebase again to pick up #337041.

@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

I'm afraid you'll have to rebase again to pick up #337041.

Done

@alyssais
Copy link
Member

error: builder for '/nix/store/00raa9m95cjc6iafn442y2j1y4z6lrni-source.drv' failed with exit code 1;
       last 8 log lines:
       >
       > trying https://github.com/tursodatabase/libsql/archive/libsql-server-v0.24.18g.tar.gz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download source from any mirror

Hmm, that's not good

@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

Bah. Typo g

pkgs/servers/sql/sqld/default.nix Outdated Show resolved Hide resolved
@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

Fixed

Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying https://github.com/tursodatabase/libsql/archive/libsql-server-v0.24.18.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 27.5M    0 27.5M    0     0  6531k      0 --:--:--  0:00:04 --:--:-- 7432k
unpacking source archive /build/libsql-server-v0.24.18.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/yxgrrsg0l2lwgyr965s688zxkyi6bg50-source.drv':
         specified: sha256-C9ze9o23n7v4NOotuKnOksK90FbhU0P+Rfnt64NZTQ8=
            got:    sha256-/0Sk55GBjUk/FeIoq/hGVaNGB0EM8CxygAXZ+ufvWKg=

@rawkode
Copy link
Member Author

rawkode commented Aug 24, 2024

I must have messed up my rebase for that to be incorrect.

Resolved again.

@alyssais alyssais merged commit f2a252b into NixOS:master Aug 24, 2024
24 of 26 checks passed
@rawkode rawkode deleted the sqld branch August 25, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants