-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix channel blockers for Rust 1.80 #332176
Conversation
Required to build with Rust 1.80. Link: rust-lang/rust#127343
Required to build with Rust 1.80. Link: rust-lang/rust#127343
Required to build with Rust 1.80. Link: rust-lang/rust#127343
Ack on the nsncd change. |
I'm not 100% sure this is fixed on Nsncd's side. See twosigma/nsncd#117 (comment) and https://github.com/srd424/nsncd/actions/runs/10235189099/job/28315666470#step:6:83 . That's a lot to rebuild, I'll wait for hydra to rebuild everything. I'll fix that upstream if the issue is still here. |
Hmm, I thought I built it with 1.80, but it's of course possible I could have made a mistake! |
Okay, I get it. The 1.4.1 release dates from May 2023 and do not contain the latest network fixes we pushed late 2023. 1.4.1 can be considered as broken for NixOS. We did a rollback here (not your fault just to be clear). However, 1.4.1 do not depend on time yet (through the term crate). The current main depends on time I'll fix that tonight and ask upstream to cut a new release. |
Oh no, I must have missed the year! |
No worries, mistakes happen. This one is on us: we should cut out a new release. |
Upstream issue: twosigma/nsncd#118 |
Description of changes
Rust 1.80.0 contains a major unfixable compilation regression that affects all but recent versions of the widely-used "time" crate. This is going to impact a lot of Rust software in Nixpkgs. In this PR, I've focused on identifying packages that would block the channels if we updated to Rust 1.80 without updating them. I can't yet confirm that this is an exhaustive list, but I don't think it's far off.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.