Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulauncher: add pyasyncore for Python 3.12 compat #327753

Closed
wants to merge 1 commit into from

Commits on Jul 16, 2024

  1. ulauncher: add pyasyncore for Python 3.12 compat

    asyncore has been removed from Python 3.12. For applications that still
    need it, the pyasyncore dependency can be explicitly added. So that's
    what we'll do.
    
    After nixpkgs updated to Python 3.12, I began getting the following
    traceback when starting ulauncher.
    
        Traceback (most recent call last):
          File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/bin/.ulauncher-wrapped", line 28, in <module>
            from ulauncher.main import main
          File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/lib/python3.12/site-packages/ulauncher/main.py", line 25, in <module>
            from ulauncher.ui.windows.UlauncherWindow import UlauncherWindow
          File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/lib/python3.12/site-packages/ulauncher/ui/windows/UlauncherWindow.py", line 37, in <module>
            from ulauncher.search.apps.app_watcher import start as start_app_watcher
          File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/lib/python3.12/site-packages/ulauncher/search/apps/app_watcher.py", line 7, in <module>
            import pyinotify
          File "/nix/store/8bxngdzbnzig8ddw0ypdg1plsmrpqmi2-python3.12-pyinotify-0.9.6/lib/python3.12/site-packages/pyinotify.py", line 71, in <module>
            import asyncore
        ModuleNotFoundError: No module named 'asyncore'
    
    Adding pyasyncore to propagatedBuildInputs solves this and ulauncher
    functions normally with no errors logged.
    cluther committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a4d0901 View commit details
    Browse the repository at this point in the history