vaultwarden: 1.30.5 -> 1.31.0

[wahjava]

Description of changes

https://github.com/dani-garcia/vaultwarden/releases/tag/1.31.0

https://github.com/dani-garcia/bw_web_builds/releases/tag/v2024.5.1b

Fixes #325679

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

closes #325727

---

Add a 👍 reaction to pull requests you find important.

[jackyliu16]

You may want to add yourself as maintainers of this packages.

[dotlambda]

The backup test fails. Is

cp: cannot copy a directory, '/var/lib/vaultwarden/backups', into itself, '/var/lib/vaultwarden/backups/backups'

expected? It also occurs when I run the test on master but the test doesn't fail.
cc @Scrumplex @caffineehacker

[Scrumplex]

The backup test fails. Is

cp: cannot copy a directory, '/var/lib/vaultwarden/backups', into itself, '/var/lib/vaultwarden/backups/backups'

expected? It also occurs when I run the test on master but the test doesn't fail.

This was caused by #318933. For some reason the backup test has its backup directory set to /var/lib/vaultwarden which is now also the default directory for stateVersion >= 24.11. This should only affect the test unless people changed the default /var/backup/vaultwarden path.

[Scrumplex]

See #325861 for the backup script issue

[dotlambda]

This was caused by #318933. For some reason the backup test has its backup directory set to /var/lib/vaultwarden which is now also the default directory for stateVersion >= 24.11. This should only affect the test unless people changed the default /var/backup/vaultwarden path.

That doesn't explain the test succeeding on master but failing for this PR.

[SuperSandro2000]

You may want to add yourself as maintainers of this packages.

No, we don't need more maintainers to defuse ownership just because one update wasn't done immediately. The last release is only 18 hours old.

[SuperSandro2000]

Two are fine, we don't need another one.

[Scrumplex]

That doesn't explain the test succeeding on master but failing for this PR.

In my case the test succeeded on master but showed the same error you mentioned. The test was just faulty IMO

[dotlambda]

In my case the test succeeded on master but showed the same error you mentioned. The test was just faulty IMO

The test succeeds on master for me too, but fails when I check out 1b8364eb8cfa.

[Scrumplex]

The test fails in this PR with this output:

Test "Check that backup exists" failed with error: "command `[ -f "/var/lib/vaultwarden/backups/rsa_key.pub.pem" ]` failed (exit code 1)"

Is it possible that this file doesn't exist anymore?

[dotlambda]

Is it possible that this file doesn't exist anymore?

Indeed: dani-garcia/vaultwarden#4085

[SuperSandro2000]

Is it possible that this file doesn't exist anymore?

Indeed: dani-garcia/vaultwarden#4085

Thanks for digging that up! When that fixes the test, I push the change to this PR.

I also applied the other review comments.

[Scrumplex]

@ofborg test vaultwarden.sqlite-backup