Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] keycloak: 24.0.5 -> 25.0.6 #323480

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Jun 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably failing because the feature name is not valid. I also saw references to hostname:v1 in the docs, but it's seems the feature name is hostname-v1.
Source: https://www.keycloak.org/server/features

pkgs/servers/keycloak/default.nix Show resolved Hide resolved
@mweinelt
Copy link
Member

mweinelt commented Jul 11, 2024

Any particular reason for this backport? And is it free of breaking changes?

@teutat3s
Copy link
Member

Any particular reason for this backport? And is it free of breaking changes?

#318814 (comment)

@teutat3s
Copy link
Member

Some additional observations that caught my eye while trying to debug this. I could not spot clues to a solution yet.

❯ nix build --print-build-logs -f . nixosTests.keycloak.postgres.driverInteractive
...
WARN  [org.key.com.Profile] (main) Deprecated features enabled: hostname:v1
WARN  [org.key.qua.run.cli.Picocli] (main) The following run time non-cli options were found, but will be ignored during build time:
  kc.db-url-host, kc.db-url-database, kc.db-url-port, kc.db-url-properties, kc.db-username, kc.db-password, kc.hostname,
  kc.hostname-strict-backchannel, kc.http-host, kc.http-port, kc.https-port, kc.https-certificate-file, kc.https-certificate-key-file, kc.proxy
...

and

$ kc.sh --config-file /nix/store/j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf show-config
Current Mode: production
Current Configuration:
	kc.config.built =  true (SysPropConfigSource)
	kc.config.file =  /nix/store/j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf (SysPropConfigSource)
	kc.db =  postgres (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.db-password =  ******* (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.db-url-database =  keycloak (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.db-url-host =  localhost (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.db-url-port =  5432 (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.db-url-properties =   (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.db-username =  keycloak (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.hostname =  acme.test (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.http-host =  0.0.0.0 (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.http-port =  80 (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.http-relative-path =  / (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.https-certificate-file =  /run/keycloak/ssl/ssl_cert (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.https-certificate-key-file =  /run/keycloak/ssl/ssl_key (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.https-port =  443 (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.log-console-output =  default (classpath keycloak.conf)
	kc.proxy =  none (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.spi-hostname-v2-hostname =  acme.test (j05dgml8criznlavvxz9yd9zp7rirshy-keycloak.conf)
	kc.version =  25.0.1 (SysPropConfigSource)

@NickCao NickCao changed the title [Backport release-24.05] keycloak: 24.0.5 -> 25.0.1 [Backport release-24.05] keycloak: 24.0.5 -> 25.0.6 Oct 5, 2024
@NickCao NickCao marked this pull request as ready for review October 5, 2024 00:49
@NickCao
Copy link
Member Author

NickCao commented Oct 5, 2024

In an unexpected turn of events, I found out why this was not working in #346439

@teutat3s
Copy link
Member

teutat3s commented Oct 7, 2024

Result of nixpkgs-review pr 323480 run on x86_64-linux 1

3 tests built:
  • nixosTests.keycloak.mariadb
  • nixosTests.keycloak.mysql
  • nixosTests.keycloak.postgres
1 package built:
  • pkgs.keycloak

@teutat3s
Copy link
Member

teutat3s commented Oct 7, 2024

@ofborg test keycloak

@NickCao
Copy link
Member Author

NickCao commented Oct 7, 2024

Let's add the commit raising test vm memory size, should help with the flaky tests.

@NickCao
Copy link
Member Author

NickCao commented Oct 8, 2024

So they only support one major version: https://endoflife.date/keycloak

We might as well leave it as is. Version 25 is no better than 24 in terms of support now.

@dkowis
Copy link

dkowis commented Oct 10, 2024

https://www.keycloak.org/2024/10/release-updates

Just FYI, keycloak is changing the way they do releases so that it's less disruptive, and hopefully this will be easier to deal with.

NickCao and others added 3 commits October 10, 2024 19:32
(cherry picked from commit 5182f25)
(cherry picked from commit 84c49af)
@NickCao NickCao merged commit eea0382 into NixOS:release-24.05 Oct 11, 2024
23 of 25 checks passed
@NickCao NickCao deleted the keycloak-backport branch October 11, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants