Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.telescope-emoji-nvim: init at 2022-12-08 #313731

Closed
wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link
Member

Description of changes

Adding a VIM plugins that let users interactively search for emojis using telescope.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pamplemousse
Copy link
Member Author

Pamplemousse commented May 22, 2024

https://nixos.org/manual/nixpkgs/stable/#adding-new-plugins-to-nixpkgs is unclear about what needs to be done to have a simple vim plugin added as a package.

nix run .#vimPluginsUpdater created a bunch of unwanted commits, but they seem necessary for the plugin package to be usable...

I ended up reading the diffs, picking what is relevant, and ignoring the rest.

@PerchunPak
Copy link
Member

PerchunPak commented Aug 23, 2024

Hi @Pamplemousse,

This plugin relies on telescope-nvim. Would it be possible to add it as a dependency, similar to here?

Also try git commit --amend --no-edit --reset-author to display your username in the commit.

@PerchunPak
Copy link
Member

I ended up reading the diffs, picking what is relevant, and ignoring the rest.

Unfortunately, this is the right approach. I fixed it in #336137, but it is not merged yet. I will also update docs (probably)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants