Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letterpress: init at 2.1 #313689

Merged
merged 1 commit into from
May 28, 2024
Merged

letterpress: init at 2.1 #313689

merged 1 commit into from
May 28, 2024

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented May 22, 2024

Description of changes

As part of: #195280

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dawidd6 dawidd6 marked this pull request as ready for review May 22, 2024 17:36
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 22, 2024
pkgs/by-name/le/letterpress/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/le/letterpress/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/le/letterpress/package.nix Show resolved Hide resolved
@Aleksanaa
Copy link
Member

My preview isn't shown in monospace font, but I'm not sure if it's a font configuration problem. Are you the same?

image

@Aleksanaa Aleksanaa mentioned this pull request May 27, 2024
31 tasks
@dawidd6
Copy link
Contributor Author

dawidd6 commented May 27, 2024

I'm not sure if we should include this project in nixpkgs.

Project's author is reluctant on supporting other packaging formats (other than flatpak):
https://gitlab.gnome.org/World/Letterpress/-/merge_requests/16#note_2120586

Also the thumb down on this PR from them is telling.

@Aleksanaa
Copy link
Member

It's up to you. I don't consider that as a problem as long as you can make it work.

@dawidd6
Copy link
Contributor Author

dawidd6 commented May 27, 2024

My preview isn't shown in monospace font, but I'm not sure if it's a font configuration problem. Are you the same?

image

Looks fine in a fresh VM:

image

Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I get monospaced output in i3.

@marcusramberg marcusramberg merged commit f807ccb into NixOS:master May 28, 2024
23 of 24 checks passed
@dawidd6 dawidd6 deleted the letterpress branch May 28, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants