Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: enable canokey by default #311914

Merged
merged 4 commits into from
May 22, 2024
Merged

qemu: enable canokey by default #311914

merged 4 commits into from
May 22, 2024

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    11dd592 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ab410d View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Configuration menu
    Copy the full SHA
    eed6d26 View commit details
    Browse the repository at this point in the history
  2. qemu: enable canokey by default

    Given that we were overriding qemu_test to enable this anyway,
    enabling this by default saves Hydra a QEMU build.
    
    There's also clear demand from users[1] for this feature, so our
    alternatives are:
    
     - Offer a qemu-canokey attribute.  I don't want to do this, because I
       don't think there's any reason to make Hydra build an extra QEMU.
    
     - Enable it only for qemu_test.  I don't want to do this, because it
       will lead to users using qemu_test without understanding its
       subtleties.
    
     - Force users to build from source.  I don't think there's any reason
       to do this when it's unlikely to hurt anybody having it enabled by
       default.  There's no reason to single out canokey to be disabled by
       default in spite of users' needs given that we enable so many other
       optional QEMU features.
    
    [1]: canokeys/canokey-qemu#6
    alyssais committed May 18, 2024
    Configuration menu
    Copy the full SHA
    912edce View commit details
    Browse the repository at this point in the history