espanso: 2.1.8 -> 2.2-unstable-2024-05-14 #311724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would really love to get my Darwin changes integrated as well, outlined in #291484 I can make them as a separate PR. Most importantly, I think this pre-release should contain espanso/espanso@471c284 which fixes a runtime crash-on-launch for aarch64-Darwin (I can confirm soon). |
malt3
changed the title
I tried to incorporate your changes here. Please tell me if this is correct! |
malt3
force-pushed
the
espanso-2-2-1
branch
2 times, most recently
from
2aff9af to
71969bb
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
n8henrie
approved these changes
May 16, 2024
katexochen
reviewed
May 16, 2024
malt3
force-pushed
the
espanso-2-2-1
branch
2 times, most recently
from
86cd254 to
5822e09
Compare
eliandoran
reviewed
May 19, 2024
This commit also removes patches that seem no longer necessary, removes `--replace` calls that were not working, and uses `--replace-fail` going forward in keeping with the deprecation of `--replace`. Co-authored-by: Nathan Henrie <[email protected]>
|
Result of 2 packages built:
|
katexochen
added
the
12.approvals: 1
katexochen
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upgrade espanso to a pre-release version to fix rendering issue on wayland.
This PR is on the
devbranch, but not yet in a release: espanso/espanso#1901Without it, the tool is broken under wayland.
I am unable to test this under darwin.
Closes #286384, closes #291484.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.