Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cano: 0-unstable-2024-31-3 -> 0.1.0-alpha #301955

Merged
merged 1 commit into from
May 24, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Move to version 0.1.0-alpha

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient
Copy link
Member Author

Result of nixpkgs-review pr 301955 run on x86_64-linux 1

1 package built:
  • cano

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 6, 2024
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Apr 20, 2024

@Aleksanaa not sure why ofborg is failing, may you help investigating it?

@Aleksanaa
Copy link
Member

@ofborg eval

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Apr 20, 2024

@Aleksanaa It was a bug introduced in master (see #305610) and was fixed by #305609.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1629

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That v0.1.0-alpha is not 6b3488545b4180f20a7fa892fb0ee719e9298ddc so you definitely need to update the hash, otherwise you are still building against the old source.

@Aleksanaa Aleksanaa dismissed their stale review May 18, 2024 12:05

addressed

@Aleksanaa Aleksanaa merged commit 6f1c0c2 into NixOS:master May 24, 2024
24 checks passed
@Sigmanificient Sigmanificient deleted the cano-alpha branch May 24, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants