Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metronome: init at 1.3.0 #292974

Merged
merged 1 commit into from
Mar 9, 2024
Merged

metronome: init at 1.3.0 #292974

merged 1 commit into from
Mar 9, 2024

Conversation

Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented Mar 3, 2024

Description of changes

Part of #195280 (But this is not in GNOME Apps anymore?)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gaykitty
Copy link
Contributor

gaykitty commented Mar 9, 2024

Result of nixpkgs-review pr 292974 run on x86_64-linux 1

1 package built:
  • metronome

@gaykitty
Copy link
Contributor

gaykitty commented Mar 9, 2024

LGTM and runs fine.

@wegank
Copy link
Member

wegank commented Mar 9, 2024

Result of nixpkgs-review pr 292974 run on aarch64-darwin 1

1 package built:
  • metronome

@wegank
Copy link
Member

wegank commented Mar 9, 2024

Runs fine on darwin.

@wegank wegank merged commit dd64599 into NixOS:master Mar 9, 2024
23 checks passed
@Aleksanaa Aleksanaa mentioned this pull request May 2, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants