Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element-{web,desktop}: 1.11.53 -> 1.11.54 #281458

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

yayayayaka
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yu-re-ka yu-re-ka merged commit e862ac6 into NixOS:master Jan 17, 2024
5 of 6 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@McSinyx
Copy link
Member

McSinyx commented Jan 18, 2024

Element 1.11.54 works with neither Dendrite nor Conduit, should this be reverted?

@yu-re-ka
Copy link
Contributor

Element 1.11.54 works with neither matrix-org/dendrite#3304 nor Conduit, should this be reverted?

So let's say we reverted it. And then? I don't think the Element team will do anything about it.
Also "works with neither" seems to be not quite true. From the linked issue:

It seems to be working correctly, but a pop-up with "<...>"

So it just shows a warning, but then continues to work fine.

@65a
Copy link

65a commented Jan 19, 2024

@yu-re-ka fwiw, registration is currently impossible with a dendrite homeserver afaict

@Mic92
Copy link
Member

Mic92 commented Jan 19, 2024

Longterm we need to package two versions potentially of element-web, I think.

@65a
Copy link

65a commented Jan 20, 2024

@Mic92 if it helps they rolled back this change in HEAD, so hopefully you don't need to maintain multiple versions, it seems to be an error

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Jan 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants