Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blivet-gui: init at 2.5.0 #276662

Merged
merged 4 commits into from
Nov 8, 2024
Merged

blivet-gui: init at 2.5.0 #276662

merged 4 commits into from
Nov 8, 2024

Conversation

CyberShadow
Copy link
Contributor

@CyberShadow CyberShadow commented Dec 25, 2023 •
edited
Loading

Description of changes

This adds:

  • blivet, a Python library for managing storage
  • blivet-gui, a GUI using said library (something like gparted, but also supports things like LVM)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@CyberShadow CyberShadow mentioned this pull request Dec 25, 2023
Closed
12 tasks
CyberShadow
CyberShadow commented Dec 25, 2023
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/blivet-gui/default.nix Outdated Show resolved Hide resolved
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 25, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 25, 2023
@ofborg ofborg bot requested a review from AndersonTorres December 25, 2023 08:54
@ofborg ofborg bot requested a review from JohnAZoidberg December 25, 2023 15:23
@CyberShadow

This comment was marked as outdated.

Sign in to view
@CyberShadow CyberShadow marked this pull request as ready for review December 25, 2023 16:02
@CyberShadow
Copy link
Contributor Author

CC @icyrockcom (#214073), @siryoussef (#257955), @jfvillablanca (#260572), @aszlig (b0f4ae6) 🙂

@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch 2 times, most recently from 3a966e9 to 2448458 Compare December 25, 2023 17:52
@AndersonTorres
Copy link
Member

ping

@CyberShadow
Copy link
Contributor Author

ping

Yes, how to move forward here?

@wegank wegank added 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jul 4, 2024
@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch from 2448458 to c3b048d Compare July 13, 2024 16:10
@CyberShadow CyberShadow requested a review from natsukium as a code owner July 13, 2024 16:10
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 13, 2024
@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch 3 times, most recently from b04c270 to 3e14117 Compare July 13, 2024 16:38
@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch from 49ada64 to 0cb061d Compare July 14, 2024 04:45
@CyberShadow CyberShadow changed the title blivet-gui: init at 2.4.2 blivet-gui: init at 2.5.0 Jul 14, 2024
@CyberShadow
Copy link
Contributor Author

CyberShadow commented Jul 27, 2024 •
edited
Loading

@AndersonTorres This is ready for review, if you'd like to have a look.

@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch from 0cb061d to 48b40c3 Compare July 27, 2024 10:10
@theotheroracle
Copy link
Contributor

theotheroracle commented Sep 7, 2024 •
edited
Loading

i tried to nix run github:CyberShadow/nixpkgs/pull-20231224-104834#blivet-gui but i get error: nose-1.3.7 not supported for interpreter python3.12 did i run it wrong ?

@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch 2 times, most recently from c2419bd to fbd991d Compare September 8, 2024 05:07
@CyberShadow
Copy link
Contributor Author

@theotheroracle Looks like an instance of #325657. I've rebased and it seems to be working now.

Aleksanaa
Aleksanaa reviewed Sep 8, 2024
View reviewed changes
pkgs/development/python-modules/blivet/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/blivet/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/blivet/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/blivet/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/libbytesize/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/blivet-gui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/blivet-gui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/blivet-gui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/blivet-gui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/blivet-gui/package.nix Outdated Show resolved Hide resolved
@CyberShadow CyberShadow force-pushed the pull-20231224-104834 branch 2 times, most recently from a1bc4e2 to 4e4e08a Compare September 8, 2024 07:04
@CyberShadow
Copy link
Contributor Author

@Aleksanaa Thank you for the review, I applied all suggestions except the adwaita-icon-theme one, as that breaks running the software for me.

Aleksanaa
Aleksanaa reviewed Sep 8, 2024
View reviewed changes
pkgs/by-name/li/libbytesize/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/libbytesize/package.nix Outdated Show resolved Hide resolved
@CyberShadow CyberShadow mentioned this pull request Sep 8, 2024
Closed
@CyberShadow
Copy link
Contributor Author

@Aleksanaa Thank you for the suggestions, I think this is ready for another look when you have a moment.

FliegendeWurst
FliegendeWurst requested changes Nov 7, 2024
View reviewed changes
pkgs/by-name/bl/blivet-gui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/libbytesize/package.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libblockdev/default.nix Outdated Show resolved Hide resolved
@CyberShadow
libbytesize: fix Python bindings
387bdb9
@CyberShadow
libblockdev: split out Python bindings
e09aa2e 
Allow overriding Python without requiring that the entire dependency
graph (e.g. udisks) to be built against that Python.
@CyberShadow
blivet: init at 3.10.1
1813aaf
@CyberShadow
blivet-gui: init at 2.5.0
052b265
@Aleksanaa Aleksanaa merged commit a87d070 into NixOS:master Nov 8, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t4ccer t4ccer t4ccer left review comments

@Aleksanaa Aleksanaa Aleksanaa left review comments

@jtojnar jtojnar jtojnar left review comments

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blivet-gui
9 participants
@CyberShadow @AndersonTorres @theotheroracle @jtojnar @FliegendeWurst @Aleksanaa @t4ccer @wegank @NixOSInfra