Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 2.1.12 → 2.1.13-unstable-2023-08-02 #246300

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Jul 31, 2023

https://github.com/openzfs/zfs/commits/zfs-2.1.13-staging

With anecdote from a NixOS user that it’s working
openzfs/zfs#15125

…working for me as well as I built+booted from this commit.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100 labels Jul 31, 2023
@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 4 times, most recently from ba037ed to a0ca097 Compare August 2, 2023 12:34
@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 2 times, most recently from 622e5e7 to fad8061 Compare August 3, 2023 04:49
@toastal toastal changed the title zfsUnstable: 2.1.12 → 2.1.13-unstable-2023-07-26 zfsUnstable: 2.1.12 → 2.1.13-unstable-2023-08-02 Aug 3, 2023
@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch from fad8061 to 98c03c6 Compare August 3, 2023 13:35
@toastal
Copy link
Contributor Author

toastal commented Aug 3, 2023 via email

@RaitoBezarius
Copy link
Member

I didn't write this if?

Yes you didn't but you should keep the semantics :P.

@toastal
Copy link
Contributor Author

toastal commented Aug 4, 2023

Oh, so it was removed in the last commit. I see what y’all’re trying to say now.

@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 9 times, most recently from 8e8cb71 to 98ddb47 Compare August 8, 2023 13:34
@toastal
Copy link
Contributor Author

toastal commented Aug 8, 2023

The update has been pushed a while ago.

@toastal
Copy link
Contributor Author

toastal commented Aug 8, 2023

I’ve been booting successfully from this commit (with rebases) for a week now.

@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 6 times, most recently from 10ad718 to ab50ee3 Compare August 11, 2023 17:59
@toastal
Copy link
Contributor Author

toastal commented Aug 12, 2023

This has built & been successfully ran for me from kernels

  • 6.4.6
  • 6.4.7
  • 6.4.8
  • 6.4.9
  • 6.4.10
  • 6.4.11

@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 8 times, most recently from 1b4a116 to e53f902 Compare August 18, 2023 18:14
@magneticflux-
Copy link
Contributor

Should zfsUnstable track the 2.2.0 release candidates, or just the staging branch of the next patch?

@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 2 times, most recently from 4bdfdb7 to 7531a7a Compare August 19, 2023 15:35
@toastal
Copy link
Contributor Author

toastal commented Aug 19, 2023

@magneticflux-

https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/zfs/unstable.nix#L20-L22

Historically & according to this comment, zfsUnstable points to the most recent staging. If you’re here because you too would like to keep on the latest stable Linux kernel, I too am not sure what the hold up is as this unstable is supposed to follow latest staging from OpenZFS. On that note: tested on 6.4.11 with success too. I’ve been rebasing often tho because I’m using this branch as my machines’ Nixpkgs while I await a merge to stay with 6.4.x.

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Aug 19, 2023 via email

@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch 2 times, most recently from 952b998 to 7c5b388 Compare August 20, 2023 10:40
@toastal
Copy link
Contributor Author

toastal commented Aug 20, 2023

@RaitoBezarius but the last commit for 2.1.13 staging in upstream is @RaitoBezarius ’s own commit. Didn’t you test before it was merged?? 😅

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Aug 20, 2023 via email

@toastal
Copy link
Contributor Author

toastal commented Aug 20, 2023 via email

@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch from 7c5b388 to 8c3415b Compare August 21, 2023 06:36
https://github.com/openzfs/zfs/commits/zfs-2.1.13-staging

With anecdote from a NixOS user that it’s working
openzfs/zfs#15125

…working for me as well as I built+booted from this commit.
@toastal toastal force-pushed the zfs-2.1.13-unstable-2023-07-26 branch from 8c3415b to d687c82 Compare August 21, 2023 12:43
@RaitoBezarius RaitoBezarius merged commit 91f799f into NixOS:master Aug 21, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants