zfs: make it compatible with bcachefs #243075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
Artturin
reviewed
Jul 12, 2023
| #define kmem_cache_destroy(skc) spl_kmem_cache_destroy(skc) | ||
| + | ||
| +/* This is necessary to be compatible with bcachefs for example. */ | ||
| +#undef kmem_cache_alloc |
There was a problem hiding this comment.
I will upstream it yes
There was a problem hiding this comment.
This is upstreamed in 2.1.13 and 2.2.x.
|
I can report that I have now ZFS and bcachefs on the same machine, it's bliss. |
13 tasks
RaitoBezarius
force-pushed
the
bcachefs-and-zfs
branch
from
3fc5fdf
to
2cd9db1
Compare
Due to the existence of `kmem_cache_alloc` in bcachefs codebase, you need to undefine the symbol to make it usable by the ZFS module.
RaitoBezarius
force-pushed
the
bcachefs-and-zfs
branch
from
2cd9db1
to
728684c
Compare
|
Closing, this is already upstream now I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Due to the existence of
kmem_cache_allocin bcachefs codebase, you need to undefine the symbol to make it usable by the ZFS module.I will test this on myself first, tested with
pkgs.linuxPackages_testing_bcachefs.zfs.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)