Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll fixes #240000

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Jekyll fixes #240000

merged 2 commits into from
Aug 6, 2023

Conversation

aidalgol
Copy link
Contributor

Description of changes

Fixes for two Jekyll issues:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin
Copy link
Member

Artturin commented Aug 6, 2023

Result of nixpkgs-review pr 240000 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • discourse
  • discourseAllPlugins
  • rubyPackages_2_7.webrick
3 packages built:
  • rubyPackages.webrick (rubyPackages_3_1.webrick)
  • rubyPackages_3_0.webrick
  • rubyPackages_3_2.webrick

@Artturin Artturin merged commit 5c5bdd7 into NixOS:master Aug 6, 2023
TheNeikos added a commit to TheNeikos/nixpkgs that referenced this pull request Sep 13, 2023
This was fixed globally in NixOS#240000 and thus is not needed here anymore.
pdg137 pushed a commit to pdg137/nixpkgs that referenced this pull request Oct 21, 2023
This was fixed globally in NixOS#240000 and thus is not needed here anymore.

# Conflicts:
#	pkgs/servers/web-apps/discourse/default.nix
@aidalgol aidalgol deleted the jekyll-fixes branch August 19, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants