-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] create maintainers/categories-set.nix #230439
[wip] create maintainers/categories-set.nix #230439
Conversation
aef66c7
to
cc03cd0
Compare
I guess what is needed is also adding category to the meta attribute whitelist? |
Isn't this an ofborg-specific config? |
There is a list in the manual, and there is |
cc03cd0
to
b39cf61
Compare
Here is the current listing of files inside pkgs directory. They can be useful for filling the categories set. |
7a7b6a2
to
2e7274c
Compare
@7c6f434c can you please check this again? |
doc/stdenv/meta.chapter.md
Outdated
@@ -244,6 +244,10 @@ Unfree package that cannot be redistributed. You can build it yourself, but you | |||
|
|||
This package supplies unfree, redistributable firmware. This is a separate value from `unfree-redistributable` because not everybody cares whether firmware is free. | |||
|
|||
## Categories {#sec-meta-categories} | |||
|
|||
The categories of the package. A list of attributes from the attribute set defined in [`nixpkgs/lib/categories-set.nix`](https://github.com/NixOS/nixpkgs/blob/master/lib/categories-set.nix). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The categories of the package. A list of attributes from the attribute set defined in [`nixpkgs/lib/categories-set.nix`](https://github.com/NixOS/nixpkgs/blob/master/lib/categories-set.nix). | |
The `meta.categories` attribute contains the categories of the package. A list of attributes from the attribute set defined in [`nixpkgs/lib/categories-set.nix`](https://github.com/NixOS/nixpkgs/blob/master/lib/categories-set.nix). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think the attribute name should be made explicit like in other entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain? I'm not understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some sections are titled with exact (including capitalisation) name of the meta attribute. Some sections include the full name in the text near the beginning. Some do both.
The proposed section here does neither, thus my suggestion to add meta.categories
into the text of the section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
1481d18
to
4907534
Compare
@7c6f434c what do you think of the example of |
eee01ba
to
fc3f188
Compare
I think it works fine as an example, but it feels a bit weird to add specifically «assembler» and not «compiler» |
fc3f188
to
a14e9eb
Compare
Well, the idea is that OK, assemblers are compilers in a broader sense; however, this would be a case for Also, it shows the basic ideas of the data structure. |
a14e9eb
to
010a740
Compare
«assembler → compiler → development» maybe with the transitive «assembler → development» would look natural (with the implication that we don't fill everything, it is just a demonstration), or as you proposed initially «audio → audioVideo» and tag some minor sound processing application like |
I suggest, then, to never fill the "transitive closure" of every category, in the sense of e.g. |
13efdb0
to
9779b4d
Compare
Now it should work as a POC |
9779b4d
to
6aee49b
Compare
58f7d72
to
e41bc92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We will obviously need a bit more process documentation in the manual, but this will need to take into account the choices made in the RFC process)
As a proof-of-concept for NixOS/rfcs#146
As a proof-of-concept for NixOS RFC 146 Double wip because it lacks the descriptions.
e41bc92
to
b45a1d3
Compare
Speaking of base categories, one thing definitionally not covered by Freedesktop is «data assets» — fonts, themes, icon packs, game levels (e.g. when the core is built on Hydra and unpacking a gigabyte of 3D models has empty hydraPlatforms), and other things one doesn't launch from an application menu. |
check-meta conflicted, closing. |
As a proof-of-concept for NixOS/rfcs#146
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)