Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 112.0.5615.165 -> 113.0.5672.63 #229759

Merged
merged 1 commit into from
May 4, 2023
Merged

chromium: 112.0.5615.165 -> 113.0.5672.63 #229759

merged 1 commit into from
May 4, 2023

Conversation

primeos
Copy link
Member

@primeos primeos commented May 3, 2023

https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop.html

This update includes 15 security fixes.

CVEs:
CVE-2023-2459 CVE-2023-2460 CVE-2023-2461 CVE-2023-2462 CVE-2023-2463 CVE-2023-2464 CVE-2023-2465 CVE-2023-2466 CVE-2023-2467 CVE-2023-2468

Description of changes

Note: Depends on LLVM 16 (#223282).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@primeos primeos added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels May 3, 2023
@ofborg ofborg bot requested a review from thefloweringash May 3, 2023 22:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels May 3, 2023
@edrex
Copy link
Contributor

edrex commented May 3, 2023 •
edited
Loading

There's no binary cache for nixpkgs PRs right? Wanting to see if this fixes #225277 nm, realized I can test with google-chrome-dev, which uses official build.

@edrex edrex mentioned this pull request May 3, 2023
Closed
7 tasks
@primeos
Copy link
Member Author

primeos commented May 4, 2023

I ran a local build + the VM test just to be sure this won't unnecessarily block the channel (I did test M113 in the past but it was 2-3 weeks ago):

/nix/store/n940122s1mif8gx7p0rylj0rxaagqm9c-chromium-113.0.5672.63
/nix/store/2z5r36p5an8s7p998gcnh23jflw0xnxk-vm-test-run-chromium-stable

@primeos primeos merged commit 632e826 into NixOS:master May 4, 2023
@networkException networkException mentioned this pull request May 4, 2023
Closed
12 tasks
@primeos primeos mentioned this pull request May 10, 2023
Merged
12 tasks
@primeos
Copy link
Member Author

primeos commented May 10, 2023

Manual backport in #231179.

@primeos primeos removed the 9.needs: port to stable A PR needs a backport to the stable release. label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@primeos @edrex