Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311.pkgs.asynctest: disable #216168

Closed
wants to merge 1 commit into from

Conversation

alyssais
Copy link
Member

Description of changes

Not compatible with Python 3.11.

Upstream is dead.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Not compatible with Python 3.11[1].

Upstream is dead.

[1]: Martiusweb/asynctest#161
@fabaff
Copy link
Member

fabaff commented Feb 13, 2023

Currently approx. 40 modules are still using asynctest.

@alyssais
Copy link
Member Author

Currently approx. 40 modules are still using asynctest.

Yeah, that's my motivation here. Disabling it will save time figuring out why those packages are broken.

@dotlambda
Copy link
Member

Currently approx. 40 modules are still using asynctest.

Yeah, that's my motivation here. Disabling it will save time figuring out why those packages are broken.

Not all of them are broken though, e.g. because some actually don't use asynctest anymore.
Let's try to fix as many as possible and then merge this.

@dotlambda
Copy link
Member

Previously we've also set such packages to null on the respective version of Python.

@alyssais
Copy link
Member Author

Not all of them are broken though, e.g. because some actually don't use asynctest anymore.
Let's try to fix as many as possible and then merge this.

Ahhhh didn't think of that. Yeah, makes sense. 40 isn't too many to go through I suppose.

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM fairly simple but complete change.

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 9, 2024
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@mweinelt
Copy link
Member

Disabled in 10c3f73

@mweinelt mweinelt closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants