Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ats2: add darwin support #208750

Merged
merged 2 commits into from
Jan 8, 2023
Merged

ats2: add darwin support #208750

merged 2 commits into from
Jan 8, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 2, 2023

Description of changes

Supersedes #89283.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Jan 2, 2023
@ofborg ofborg bot requested review from ttuegel, bbarker and thoughtpolice January 2, 2023 12:53
@totoroot
Copy link
Contributor

totoroot commented Jan 2, 2023

Result of nixpkgs-review pr 208750 run on x86_64-darwin 1

1 package failed to build:
  • ats-acc
1 package built:
  • ats2

@ofborg ofborg bot requested a review from moni-dz January 2, 2023 13:58
@thiagokokada thiagokokada merged commit 5dd1eee into NixOS:master Jan 8, 2023
@wegank wegank deleted the ats2-darwin branch January 8, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants