youtube-music: 0.17.0 -> 0.18.0

[rubyowo]

Description of changes

https://github.com/th-ch/youtube-music/blob/master/changelog.md#v1180

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[NobbZ]

Nixpkgs-review on x86_64-linux:

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/205418

1 package built:
youtube-music

The resulting binary could be opened and used to play the intros of some random songs and allowed navigation within. Seems to be functional.

Activating/deactivating of plugins seem to have no effect other than seeing corresponding log lines on application start, this behaviour is reproducible with the prev. version.

[aacebedo]

Did you check that mpris is working correctly?
When I tried this version I saw it was broken.

[rubyowo]

mpris works as expected (im using mpris-proxy if thats relavant)

[NobbZ]

I have no clue what mpris means. So I have not checked it consciously.

[aacebedo]

I use playerctl for that. I'll approve the modification but I can't merge

[aacebedo]

I confirm mpris is now broken on my side

[rubyowo]

mpris works here, i will note that when i tested it locally, i could theme the client but it doesn't work now?

[aacebedo]

@rubyowo I am not sure it is youtube-music which is responding here. On my machine, it appears as "youtube-music" not "chromium". If I open the website on my chromium browser it appears and works the same as you.
Can you list the mpris player with playerctl -l ?

[rubyowo]

it shows up as chromium.instance2 here

[aacebedo]

it shows up as chromium.instance2 here

how do you start it? do you run wayland?

1.17 was working correctly

[rubyowo]

I run wayland (Hyprland) and i just launch it from its .desktop file, if i launch it from the terminal it also works

[aacebedo]

I run sway. It is strange because the name is the one used by the binary to register itself in dbus (you can check it with dfeet).
I don't know what it exactly uses in the system to decide to use another name

[aacebedo]

ok. found. I had "shortcuts" enabled in the app. This seems to be based on the faulty npm libs mentioned in this bug
th-ch/youtube-music#872

deactivating it make the system to use the default system in chromium