-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collision: init at 3.3.1 #195395
collision: init at 3.3.1 #195395
Conversation
Blocked by: #173928 |
> shards install
Resolving dependencies
Fetching https://github.com/geopjr/libadwaita.cr.git
Fetching https://github.com/geopjr/gettext.cr.git
Fetching https://github.com/geopjr/non-blocking-spawn.git
Fetching https://github.com/hugopl/gtk4.cr.git
Fetching https://github.com/hugopl/gi-crystal.git
Fetching https://github.com/hugopl/version_from_shard.git
Using version_from_shard (1.2.5)
Installing gi-crystal (0.14.0)
Postinstall of gi-crystal: shards build
Installing gtk4 (0.12.0)
Installing libadwaita (1.0.0 at 72f2e42)
Installing non-blocking-spawn (1.0.5)
Installing gettext (1.0.0)
Shard "gi-crystal" may be incompatible with Crystal 1.2.2
Shard "gtk4" may be incompatible with Crystal 1.2.2
Shard "non-blocking-spawn" may be incompatible with Crystal 1.2.2
Shard "gettext" may be incompatible with Crystal 1.2.2 > ./bin/gi-crystal
info - Starting at 2022-10-10 20:57:59 +02:00, project dir: /home/annaaurora/projects/Collision
info - Generating bindings at /home/annaaurora/projects/Collision/lib/gi-crystal/src/auto
info - Using binding config at /home/annaaurora/projects/Collision/lib/gi-crystal/src/bindings/g_lib/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gi-crystal/src/bindings/g_object/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gtk4/src/bindings/gdk/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gtk4/src/bindings/gio/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gtk4/src/bindings/gsk/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gtk4/src/bindings/gtk/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gtk4/src/bindings/harfbuzz/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/gtk4/src/bindings/pango/binding.yml
info - Using binding config at /home/annaaurora/projects/Collision/lib/libadwaita/src/bindings/binding.yml
fatal - Typelib file for namespace 'Gdk', version '4.0' not found … when trying to generate the libadwaita bindings how https://github.com/GeopJr/libadwaita.cr suggests. Currently the crystal in nixpkgs is only 1.2, that's why the warnings are these and might be the cause of the fatal error. Trying again when crystal is updated. |
db031f2
to
a0ac95a
Compare
So, it build now but the executable in the result is |
oh, forgot my comments about the bindings… |
Now blocked by: #195606 |
It should not be blocked anymore! |
$ nix-build . -A collision
this derivation will be built:
/nix/store/4wwwj11zg4b29v8j9l4837294a2ii2j5-collision-3.4.0.drv
building '/nix/store/4wwwj11zg4b29v8j9l4837294a2ii2j5-collision-3.4.0.drv'...
unpacking sources
unpacking source archive /nix/store/cdshxn9jll38z93k6hc0lqrrlskiwvln-source
source root is source
patching sources
configuring
building
shards install
Resolving dependencies
Fetching https://github.com/geopjr/libadwaita.cr.git
Fetching https://github.com/geopjr/non-blocking-spawn.git
Fetching https://github.com/geopjr/gettext.cr.git
Failed to clone https://github.com/geopjr/gettext.cr.git
make: *** [Makefile:9: bindings] Error 1
/nix/store/chilfhdcsnmwjl7igrw26j1lrc0zar35-stdenv-linux/setup: line 129: pop_var_context: head of shell_variables not a function context I don't understand this error. |
Can the |
Is this better (as to not break existing scripts using it)? GeopJr/Collision@f9dec3a edit: # Assuming you have installed the shards already and the binding generator has been built
./bin/gi-crystal
shards build -Dpreview_mt --release --no-debug # or "crystal build ./src/collision.cr -Dpreview_mt --release --no-debug" to skip the shard check if the environment doesn't have network access - beware, the output location will be `./collision` instead
# anything else that you need to compile & install (translations, .desktop files, metainfo) |
So, |
On the flatpak - that doesn't have internet access during the build process and shards are cloned manually (instead of using the - cd lib/gi-crystal && crystal build src/generator/main.cr && cd ../.. && mkdir ./bin && cp lib/gi-crystal/main ./bin/gi-crystal
- ./bin/gi-crystal |
Closing since #242681 has been merged. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes