Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCMSolver Glibc Compatibility #168249

Merged
merged 2 commits into from
Apr 11, 2022
Merged

PCMSolver Glibc Compatibility #168249

merged 2 commits into from
Apr 11, 2022

Conversation

sheepforce
Copy link
Member

Description of changes

The Glibc update to 2.34 broke the PCMSolver, by changing SIGSTKSZ to a dynamic value, which leads to type errors in PCMSolvers' C++ code. I've opened an issue upstream, but PCMSolver is broken in current master, nixos-unstable, and soon probably nixpkgs-unstable. The current workaround just replaces SIGSTKSZ by _SC_SIGSTKSZ, which is provided for backwards-compatibility.
I've also replaced the python2 build dependency by python3.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants