Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prettier to dev shell #1586

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

mschwaig
Copy link
Member

No description provided.

Copy link
Contributor

@crertel crertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see comment. We may already have some of this for you.

flake.nix Outdated Show resolved Hide resolved
@mschwaig mschwaig force-pushed the add-prettier-to-dev-shell branch from c8124ff to 5de868e Compare November 21, 2024 14:54
@mschwaig
Copy link
Member Author

Actually if npm manages what version of prettier is used, then adding the one from nixpkgs to the command line might not be a good idea, so I removed that from this PR again.

I got the idea from the log of the failing format check here: https://github.com/NixOS/nixos-homepage/actions/runs/11843965454/job/33006101651

@mschwaig mschwaig requested a review from crertel November 21, 2024 14:56
@thilobillerbeck thilobillerbeck merged commit af1e5b8 into NixOS:main Nov 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants