Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro/blog [RFR] #1190

Merged
merged 25 commits into from
Dec 11, 2023
Merged

Astro/blog [RFR] #1190

merged 25 commits into from
Dec 11, 2023

Conversation

thilobillerbeck
Copy link
Collaborator

@thilobillerbeck thilobillerbeck commented Dec 9, 2023

This project reimplements the NixOS homepage /blog section with omitted Community section and on page filtering of posts as well as seperate pages per post. The content has been centralized and standardized to markdown for ease of editing.

This PR does the following things:

  • add announcements, nixos-weekly and stories to the content dir and convert them to markdown if needed
  • adjust code block theme to match with original site
  • add article view styling to match original site
  • add a blog overview with category filters (as discussed and approved in last weeks marketing call)
  • add a per entry view with discrete URLs
  • add RSS feed (one for everything and one for every category)
  • separate image behavior in blog articles and the learn section
  • adjusted header to incorporate a subheading for things like metadata

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@thilobillerbeck thilobillerbeck changed the title Astro/blog [WIP] Astro/blog [RFR] Dec 10, 2023
@thilobillerbeck thilobillerbeck marked this pull request as ready for review December 10, 2023 17:23
Copy link
Member

@djacu djacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice! I checked several of the blog entries and tried to break the filter. All seems to be working well.

side note: we should consider replacing those images on the NixOS release pages in the future. low res png doesn't look great.

---

<Layout title="Nix & NixOS">
<div class="bg-nixlighterblue">
<Container class="flex flex-col md:flex-row items-center justify-between py-4">
<b class="text-nixsemidarkblue text-lg">NixOS 23.05 released.</b>
<Button>Announcement</Button>
<b class="text-nixsemidarkblue text-lg">{posts[0].data.title}</b>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is 🤌

@@ -37,11 +37,11 @@ const {
shaText = "",
} = Astro.props;

const localClassList = `${colorMap[color]} font-bold ${sizeMap[size]} text-white drop-shadow-[0_4px_1px_rgba(0,0,0,0.2)]`;
const localClassList = `${colorMap[color]} object-contain font-bold ${sizeMap[size]} text-white drop-shadow-[0_4px_1px_rgba(0,0,0,0.2)]`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was something breaking without object-contain?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, this is just a remainder of debugging. I just removed it :D

Copy link
Contributor

@thilobillerbeck thilobillerbeck merged commit d36a631 into main Dec 11, 2023
2 checks passed
@thilobillerbeck thilobillerbeck deleted the astro/blog branch December 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants