-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Astro rework) Redesign of /community page and its subpages #1160
Conversation
Also update daisyui to 4.0, because it introduces timeline component
@kacperwyczawski how's progress going? Do you have a rough estimation of when you'll be finished? |
@thilobillerbeck can you please address this, this and this? Thanks in advance. Besides these things, everything is finished. |
Alright, with these changes I should finish on 2023-12-15 or earlier. |
I had to make more changes to the diagram animation and the diagram itself, than I thought. I'll finish it tomorrow, sorry for delay. |
@thilobillerbeck I'm ready for another review 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thx for the contributions. There are some minor nitpicks I have, but to save time on communication I will fix them myself.
Unfortunately I'm not really happy with the NixCon section, it looks crammed together now, has thick surrounding scrollbars and does not feature the old descriptions. I will roll this back to the old design but encourage you to iterate on the idea since it is interesting, it's (apart being not in the scope for this stage of the project) not really ready imo. Please don't take this personal, we just want to get this done til the end of the year and can still incorporate this in the next stage.
Anyway, thanks for the contributions and the ideas. <3
No problem, I understand your decision with NixCons section. I'm glad I could help. |
as mentioned in #1160 in this PR I rolled some changes back to reflect the original design and fixed some smaller things - adjusted rfc ratio - adjusted teams layout padding - incorporate article and tag components - remove tailwind typography since article is more consistent - reorder teams - reintroduce images to the nixcon section - fix mobile alignment for nixcon board members --------- Co-authored-by: Rok Garbas <[email protected]>
Changes:
/community
,/community/[team]
,/community/event-funding
and/community/commercial-support
to Astro4.0.4
for timeline support.yaml
or.mdx
files)MDXLayout
for creating pages in mdxhtml
tomdx
/yaml
/commercial-support
, will be active after mergeWhat can be improved in another PR: