Astro/donate page [RFR] #1145
Merged
Astro/donate page [RFR] #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
djacu
commented
Nov 5, 2023
•
djacu
commented
- Waiting on $astro/landingpage to merge to take advantage of the Button component.
- Need to fix styling on hyperlink tags.
- Need to fix styling for top header and paragraph.
- Fix external logos on small width screens.
thilobillerbeck
requested changes
Nov 6, 2023
There was a problem hiding this comment.
Looks good so far, thanks for your work. <3 There are some things I observed and annotated. :)
One thing I couldn't annotate is, that the sponsor logos are in a folder named public/images/logos. I think naming the folder something like public/images/sponsors would be more fitting, since people could easily think that there are Nix related logos inside there.
tomberek
pushed a commit
that referenced
this pull request
Nov 8, 2023
Initial work to build the landing page. There are still some components missing but to continue on with the other pages (#1145 for example) by using this pages components it would be a good idea to merge the current state into main.
…Styled the Acknowledgements logos.
…agraph in the Acknowledgements section. Increased gaps in columns for better separation. Added x-padding on the sections. Fixed the SEPA bank information so it wraps.
…t section so it looks good on all screen sizes.
… map over the info.
tomberek
force-pushed
the
astro/donate-page
branch
from
4da8b4a to
544b3ff
Compare
…components into the donate page.
garbas
approved these changes
Nov 10, 2023
thilobillerbeck
approved these changes
Nov 10, 2023
resolved |
thilobillerbeck
dismissed
tomberek’s stale review
the proposed changes have been adressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.