framework: Add Intel Core Ultra Series 1 #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Schaefer <[email protected]>
|
maybe shorter name? like |
Mic92
reviewed
Jul 9, 2024
| @@ -150,6 +150,7 @@ See code for all available configurations. | |||
| | [Framework 11th Gen Intel Core](framework/13-inch/11th-gen-intel) | `<nixos-hardware/framework/13-inch/11th-gen-intel>` | | |||
| | [Framework 12th Gen Intel Core](framework/13-inch/12th-gen-intel) | `<nixos-hardware/framework/13-inch/12th-gen-intel>` | | |||
| | [Framework 13th Gen Intel Core](framework/13-inch/13th-gen-intel) | `<nixos-hardware/framework/13-inch/13th-gen-intel>` | | |||
| | [Framework Intel Core Ultra Series 1](framework/13-inch/intel-core-ultra-series1) | `<nixos-hardware/framework/13-inch/intel-core-ultra-series1>` | | |||
There was a problem hiding this comment.
Please also reference this in the flake.nix.
|
I would love to see this shipped :) |
2 tasks
|
For anyone interested: I addressed the concerns raised above and submitted a PR to Framework. Here it is: FrameworkComputer#1 |
|
@umgefahren Just open a new PR. @JohnAZoidberg if you want to continue working on this, also just re-open this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Not selling to customers yet, but already announced: https://frame.work/tw/en/blog/introducing-the-new-framework-laptop-13-with-intel-core-ultra-series-1-processors
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input