Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added Asus Zenbook Pro ux535
Things done
I've been using NixOS on this laptop for a while now, so I figured my configuration was hopefully stable enough to be upstreamed here for others to use. All values were taken from my config, along with some other values that I've found to cause bugs if set turned off.
I found the contributing docs to be outdated when it came to running the testing python script, it seems to have had major changes made three weeks ago that have changed it's usage. The command:
./tests/run.py --jobs 4 --verbose --nixos-hardware ./.
worked for me to test all modules, I couldn't figure out how we're now meant to test only a single module (--jobs 4 is only because I ran out of Memory without a limit, and it ran quickly enough with 4 without using too much, you could probably increase this or just remove it.).nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input