Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asus Zenbook ux535 #1123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Asus Zenbook ux535 #1123

wants to merge 1 commit into from

Conversation

Green-D-683
Copy link

Description of changes

Added Asus Zenbook Pro ux535

Things done

I've been using NixOS on this laptop for a while now, so I figured my configuration was hopefully stable enough to be upstreamed here for others to use. All values were taken from my config, along with some other values that I've found to cause bugs if set turned off.

I found the contributing docs to be outdated when it came to running the testing python script, it seems to have had major changes made three weeks ago that have changed it's usage. The command: ./tests/run.py --jobs 4 --verbose --nixos-hardware ./. worked for me to test all modules, I couldn't figure out how we're now meant to test only a single module (--jobs 4 is only because I ran out of Memory without a limit, and it ran quickly enough with 4 without using too much, you could probably increase this or just remove it.).

  • [/] Tested the changes in your own NixOS Configuration
  • [/] Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant