Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Nixpkgs diffs for PRs #186

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Automated Nixpkgs diffs for PRs #186

merged 1 commit into from
Apr 5, 2024

Conversation

infinisil
Copy link
Member

Implements #163 (see for more context) by reusing the script from before. I took the time to clean up the script to a reasonable degree now though :)

For now it won't work for PRs from forks, but in turn it should work for this PR itself, let's see..

Copy link

github-actions bot commented Apr 5, 2024

Nixpkgs diff

@infinisil infinisil force-pushed the nixpkgs-ci branch 2 times, most recently from ae1703b to 45a2ca5 Compare April 5, 2024 02:17
@tomberek
Copy link
Contributor

tomberek commented Apr 5, 2024

A reasonable link to generate and put into the status? infinixbot/nixpkgs@nixfmt-186~2...infinixbot:nixpkgs:nixfmt-186

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it claims to

Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@infinisil
Copy link
Member Author

@tomberek Yeah we could do that, I'd say let's merge this for now, I'll improve this in follow-up PRs

@infinisil infinisil merged commit 35b0186 into master Apr 5, 2024
2 checks passed
@infinisil infinisil deleted the nixpkgs-ci branch April 5, 2024 22:46
This was referenced Apr 5, 2024
@infinisil
Copy link
Member Author

See #187 (comment) for a mock-up of how it could look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants