profile: add installable matcher #10198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
bobvanderlinden
force-pushed
the
profile-match-url
branch
from
1c7a767 to
6872308
Compare
This allows removing and upgrading packages using flake urls.
bobvanderlinden
force-pushed
the
profile-match-url
branch
from
abc5486 to
10a6dff
Compare
|
@edolstra could you have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows removing and upgrading packages using flake urls.
Motivation
Currently it can be surprising that using the same argument for installing a package will not work for removing them:
To make this work this PR adds another matcher (like in #10166), but now for 'installables':
flake#packageor any of the variants thereof.Context
Fixes #10064
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.