Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra: use cache.nixos.org URL for logs instead of raw S3 URLs #301

Merged
merged 1 commit into from
Nov 3, 2023
Merged

hydra: use cache.nixos.org URL for logs instead of raw S3 URLs #301

merged 1 commit into from
Nov 3, 2023

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Nov 3, 2023

We don't use Cloudfront anymore, and Fastly should be setting the proper CORS headers.

@delroth
hydra: use cache.nixos.org URL for logs instead of raw S3 URLs
a73338c 
We don't use Cloudfront anymore, and Fastly should be setting the proper
CORS headers.
@delroth
Copy link
Contributor Author

delroth commented Nov 3, 2023

(Source re: CORS: https://github.com/NixOS/nixos-org-configurations/blob/master/terraform/cache.tf#L187)

@vcunat vcunat merged commit 8b97430 into NixOS:master Nov 3, 2023
1 check passed
@delroth delroth deleted the hydra-s3-urls branch November 3, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delroth @vcunat