Add support for GENERATE ASYMMETRIC KEY PAIR #31

sosthene-nitrokey · 2022-07-29T12:28:34Z

No description provided.

This is useful because the Context is generally passed by value. The method on `LoadedContext` is currently unused by will be used in #31

This is useful because the Context is generally passed by value. The method on `LoadedContext` is currently unused but will be used in #31

sosthene-nitrokey · 2022-08-03T14:08:35Z

GENERATE ASYMMETRIC KEYPAIR is supported (outside of RSA) and seems to work. But i'll keep going with the PSO commands so that I can test if the keys are properly generated.

This is required for building openpgp-card-sequoia for testing #31

This patch adds libpcslite-dev to the package list in the Dockerfile used for the CI. This is required for #31.

sosthene-nitrokey · 2022-08-09T07:51:26Z

This PR depends on a patch for littlefs2-sys to fix the issues with bindgen similar to https://github.com/davidcole1340/ext-php-rs/pull/36/files, but I'm not sure it's the "correct" solution and that it wouldn't cause conflicts with other dependencies so I'm not certain about upstreaming it.

robin-nitrokey · 2022-08-09T08:13:04Z

It would be good to have a guideline from the bindgen developers, but I think your fix is most likely the best solution. So let’s open an upstream PR. We can always change it if we receive other instructions from bindgen.

I'm not sure about the serialization format

robin-nitrokey

Looks good, thank you! I’ve added some suggestions and questions.

src/command/data.rs

src/command/gen.rs

src/command/pso.rs

src/state.rs

robin-nitrokey · 2022-08-10T13:21:48Z

tests/crypto-sequoia.rs

+        let mut sign_card = open.signing_card().unwrap();
+        let mut signer = sign_card.signer_from_public(pubk.clone(), &|| {});
+        let data = [1; 32];
+        let signature = signer.sign(HashAlgorithm::SHA256, &data).unwrap();


Does this work with other hash algorithms too?

Yes. Looking at the openpgp-card source code it appears that for ECC the given hash is ignored: https://gitlab.com/openpgp-card/openpgp-card/-/blob/main/openpgp-card-sequoia/src/signer.rs#L156

sosthene-nitrokey · 2022-08-10T14:39:54Z

There's one weird behavior of gpg which I need to investigate. Outside of expert mode it only offers setting the key attributes to RSA, Curve25519 or nist P-384. It does not offer P-256. It's surprising. It should probably not offer P-384 given that it's not announced as supported by opcard so I'm not sure what's happening.

- Only delete the key once (it was incorrectly done twice) - Only delete the keys when the attribute has actually changed - Delete the fingerprints and generation dates when deleting the keys

sosthene-nitrokey · 2022-08-10T15:09:19Z

Ok, so it seems it's because P-256 is not supported by GPG, and that GPG doesn't offer the key attributes based what the card announces to support.

https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/keygen.c;h=80d65c444fd59cd9940d1309a3b6299c4abca311;hb=refs/heads/STABLE-BRANCH-2-2#l2409

robin-nitrokey · 2022-08-11T14:22:43Z

Thank you, merged!

sosthene-nitrokey mentioned this pull request Jul 29, 2022

Implement OpenPGP commands #3

Open

23 tasks

sosthene-nitrokey changed the title ~~[wip] Add support for GENERATE ASYMMETRIC KEYPAIR~~ [wip] Add support for GENERATE ASYMMETRIC KEY PAIR Jul 29, 2022

sosthene-nitrokey force-pushed the generate-key-pair branch from 0b21240 to 96289e6 Compare July 29, 2022 14:00

sosthene-nitrokey mentioned this pull request Jul 29, 2022

Add support for PUT DATA #34

Merged

sosthene-nitrokey force-pushed the generate-key-pair branch 5 times, most recently from 63b1d58 to 7489a8c Compare August 2, 2022 08:15

sosthene-nitrokey added a commit that referenced this pull request Aug 3, 2022

Add method for "lending" the context

2efad2d

This is useful because the Context is generally passed by value. The method on `LoadedContext` is currently unused by will be used in #31

sosthene-nitrokey mentioned this pull request Aug 3, 2022

Add method for "lending" the context #35

Merged

sosthene-nitrokey added a commit that referenced this pull request Aug 3, 2022

Add method for "lending" the context

f289d97

This is useful because the Context is generally passed by value. The method on `LoadedContext` is currently unused but will be used in #31

sosthene-nitrokey added a commit that referenced this pull request Aug 3, 2022

Add method for "lending" the context

becb528

This is useful because the Context is generally passed by value. The method on `LoadedContext` is currently unused but will be used in #31

sosthene-nitrokey added a commit that referenced this pull request Aug 3, 2022

Add method for "lending" the context

17abcbf

This is useful because the Context is generally passed by value. The method on `LoadedContext` is currently unused but will be used in #31

sosthene-nitrokey force-pushed the generate-key-pair branch 2 times, most recently from 9710205 to 8f35afe Compare August 3, 2022 13:18

sosthene-nitrokey added a commit that referenced this pull request Aug 3, 2022

Add nettle to the pipeline image

ffd92a3

This is required for building openpgp-card-sequoia for testing #31

sosthene-nitrokey mentioned this pull request Aug 3, 2022

Add nettle to the pipeline image #38

Merged

sosthene-nitrokey force-pushed the generate-key-pair branch 2 times, most recently from 4cb22cc to a05ee06 Compare August 5, 2022 17:12

sosthene-nitrokey changed the title ~~[wip] Add support for GENERATE ASYMMETRIC KEY PAIR~~ Add support for GENERATE ASYMMETRIC KEY PAIR Aug 8, 2022

robin-nitrokey added a commit that referenced this pull request Aug 8, 2022

ci: Add libpcslite-dev to Dockerfile

e7c8640

This patch adds libpcslite-dev to the package list in the Dockerfile used for the CI. This is required for #31.

robin-nitrokey added a commit that referenced this pull request Aug 8, 2022

ci: Add libpcslite-dev to Dockerfile

6677d19

This patch adds libpcslite-dev to the package list in the Dockerfile used for the CI. This is required for #31.

sosthene-nitrokey mentioned this pull request Aug 9, 2022

vpicc: Implement APDU chaining #39

Merged

sosthene-nitrokey added 3 commits August 10, 2022 14:19

Add scaffolding for key generation

f19764c

Implement Ed255 key generation support

435d1db

I'm not sure about the serialization format

Show error in failing test

e96380c

sosthene-nitrokey added 14 commits August 10, 2022 14:22

Add log on failure to parse a command

2bed90a

Fix GenerateKeyPair parsing

0de6580

Fix test input! It works! 🎉

edd3d02

Fix clippy warnings

d6edb4d

Fix false positives in tests

0807df7

Only panic after showing all output

86e088f

Fail test on failure codes from gpg

afecc46

Fix missing tty errors in gpg tests

38a30fc

Filter GPG stderr for messages happening in CI

bc0d4f4

Fix false negative in test regex

ae62998

Increase vpicc waiting time for pipeline

9bfa99e

Delete key on algorithm attribute change

21bd9d8

Fix key generation with nist_p256

e092e2c

Add decryption and aut key generation to sequoia test

8156e0a

sosthene-nitrokey force-pushed the generate-key-pair branch from a4d843f to 8156e0a Compare August 10, 2022 12:24

sosthene-nitrokey requested a review from robin-nitrokey August 10, 2022 12:24

robin-nitrokey reviewed Aug 10, 2022

View reviewed changes

sosthene-nitrokey added 3 commits August 10, 2022 16:13

fixup! Add scaffolding for key generation

195d8e9

Do not panic on unimplemented algorithm

422816e

Use named constant for TLV tag

5c5f851

Fix deletion of key on attribute change

13a6b90

- Only delete the key once (it was incorrectly done twice) - Only delete the keys when the attribute has actually changed - Delete the fingerprints and generation dates when deleting the keys

Move user presence check to backend

4705fb8

sosthene-nitrokey force-pushed the generate-key-pair branch from 4ae8a5a to 4705fb8 Compare August 11, 2022 08:50

sosthene-nitrokey mentioned this pull request Aug 11, 2022

Remove usage of the unimplemented! macro #41

Merged

robin-nitrokey merged commit 2fb3735 into main Aug 11, 2022

robin-nitrokey deleted the generate-key-pair branch August 11, 2022 14:22

robin-nitrokey mentioned this pull request Aug 11, 2022

command/pso: Change order for sign_verified reset #42

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for GENERATE ASYMMETRIC KEY PAIR #31

Add support for GENERATE ASYMMETRIC KEY PAIR #31

sosthene-nitrokey commented Jul 29, 2022

sosthene-nitrokey commented Aug 3, 2022

sosthene-nitrokey commented Aug 9, 2022

robin-nitrokey commented Aug 9, 2022

robin-nitrokey left a comment

robin-nitrokey Aug 10, 2022

sosthene-nitrokey Aug 10, 2022 •

edited

Loading

sosthene-nitrokey commented Aug 10, 2022 •

edited

Loading

sosthene-nitrokey commented Aug 10, 2022

robin-nitrokey commented Aug 11, 2022

Add support for GENERATE ASYMMETRIC KEY PAIR #31

Add support for GENERATE ASYMMETRIC KEY PAIR #31

Conversation

sosthene-nitrokey commented Jul 29, 2022

sosthene-nitrokey commented Aug 3, 2022

sosthene-nitrokey commented Aug 9, 2022

robin-nitrokey commented Aug 9, 2022

robin-nitrokey left a comment

Choose a reason for hiding this comment

robin-nitrokey Aug 10, 2022

Choose a reason for hiding this comment

sosthene-nitrokey Aug 10, 2022 • edited Loading

Choose a reason for hiding this comment

sosthene-nitrokey commented Aug 10, 2022 • edited Loading

sosthene-nitrokey commented Aug 10, 2022

robin-nitrokey commented Aug 11, 2022

sosthene-nitrokey Aug 10, 2022 •

edited

Loading

sosthene-nitrokey commented Aug 10, 2022 •

edited

Loading