nrf52_upload: Remove unused code and DFU trigger protocol #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
approved these changes
Aug 4, 2024
This patch removes nrf52_upload code that is not used by us. This also means that we no longer need the intelhex dependency, and only need the ecdsa dependency for our own code.
DFU Trigger is a mechanism for rebooting from firmware into bootloader [0]. It is used if the device does not have one of the known bootloader VID/PID combinations. As the Nitrokey 3 bootloader is not part of the whitelist, it is currently executed for every firmware update. But the Nitrokey 3 already is in bootloader mode and does not support the DFU trigger protocol, so it just delays the firmware update by 5 seconds. This patch removes the DFU trigger implementation. [0] https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.sdk5.v15.3.0%2Flib_dfu_trigger_usb.html
robin-nitrokey
force-pushed
the
nrf52-upload
branch
from
7dc5243 to
090fb68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFU Trigger is a mechanism for rebooting from firmware into bootloader. It is used if the device does not have one of the known bootloader VID/PID combinations. As the Nitrokey 3 bootloader is not part of the whitelist, it is currently executed for every firmware update. But the Nitrokey 3 already is in bootloader mode and does not support the DFU trigger protocol, so it just delays the firmware update by 5 seconds.
This PR removes the DFU trigger implementation as well as unused code that was still part of the vendored package.