Add initial project structure #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
requested review from
daringer,
mmerklinger and
sosthene-nitrokey
sosthene-nitrokey
approved these changes
Jul 22, 2024
This patch adds the initial project structure, including licenses, linters and their configuration, and a basic test case that ensures that the module can be loaded. Most tooling is taken over from pynitrokey. One notable exception is that flit is replaced by poetry. This only affects developers, not end users. We recently made the same change in nitrokey-app2 [0], so I think it makes sense to use the same tooling here. [0] Nitrokey/nitrokey-app2#172 In the CI builds, we check that both the lockfile and the latest dependency versions work. It would good to also run it for the minimum versions specified in pyproject.toml, but this is currently not supported by poetry or pip: python-poetry/poetry#3527 pypa/pip#8085
sosthene-nitrokey
approved these changes
Jul 22, 2024
daringer
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the initial project structure, including licenses, linters and their configuration, and a basic test case that ensures that the module can be loaded.
Most tooling is taken over from pynitrokey. One notable exception is that flit is replaced by poetry. This only affects developers, not end users. We recently made the same change in nitrokey-app2 (Nitrokey/nitrokey-app2#172), so I think it makes sense to use the same tooling here.
In the CI builds, we check that both the lockfile and the latest dependency versions work. It would good to also run it for the minimum versions specified in pyproject.toml, but this is currently not supported by poetry or pip: