Fix segfault when not with an NK3

Nitrokey · Dec 9, 2024 · 18147c9 · 18147c9
1 parent e67fd62
commit 18147c9
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/operations_ccid.c b/src/operations_ccid.c
@@ -66,6 +66,11 @@ int set_pin_ccid(struct Device *dev, const char *admin_PIN) {
 int nk3_change_pin(struct Device *dev, const char *old_pin, const char*new_pin) {
     libusb_device *usb_dev;
     struct libusb_device_descriptor usb_desc;
+
+    if (!dev->mp_devhandle_ccid) {
+        return RET_NO_ERROR;    
+    }
+
     usb_dev = libusb_get_device(dev->mp_devhandle_ccid);
 
     int r = libusb_get_device_descriptor(usb_dev, &usb_desc);
@@ -76,7 +81,7 @@ int nk3_change_pin(struct Device *dev, const char *old_pin, const char*new_pin)
 
 
     if (usb_desc.idVendor != NITROKEY_USB_VID || usb_desc.idProduct != NITROKEY_3_USB_PID) {
-        return 0;
+        return RET_NO_ERROR;    
     }
 
     TLV tlvs[] = {