Update ctap-types and fido-authenticator #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insignifcant changes
|
robin-nitrokey
changed the title
robin-nitrokey
force-pushed
the
cosey
branch
4 times, most recently
from
542f8ac to
28e4b28
Compare
This patch updates ctap-types so that it uses the COSE implementation in the cosey crate instead of shipping its own identical cose module. This reduces code duplication and has a small effect on the binary size. We also need to update fido-authenticator to use cosey instead of ctap_types::cosey, and we need to update cose so that it includes a fix that we previously applied to the cose module in ctap-types. Additionally, many other optimizations of ctap-types and fido-authenticator are pulled in with this patch.
sosthene-nitrokey
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates ctap-types so that it uses the COSE implementation in the cosey crate instead of shipping its own identical cose module. This reduces code duplication and has a small effect on the binary size. We also need to update fido-authenticator to use cosey instead of ctap_types::cosey, and we need to update cose so that it includes a fix that we previously applied to the cose module in ctap-types.
We use this occasion to also pull in other optimizations of ctap-types and fido-authenticator.
See also: