Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added get_item, get_attr and shape #5

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

jcabrero
Copy link
Member

No description provided.

@jcabrero jcabrero requested a review from mathias-nillion May 21, 2024 12:29
Copy link
Contributor

@mathias-nillion mathias-nillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just figured we might make GJ-elimination part of the algebra lib (since it looks to be working) instead of in a test?

Copy link
Contributor

@mathias-nillion mathias-nillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests are resolved!

@jcabrero jcabrero force-pushed the feat/add_get_attr_item branch from f58b890 to 6ea1423 Compare May 22, 2024 07:56
@jcabrero jcabrero merged commit ac4dc01 into main May 22, 2024
3 checks passed
@jcabrero jcabrero deleted the feat/add_get_attr_item branch May 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants