fix: fixed testing and added more examples #10
Conversation
jcabrero
force-pushed
the
feat/fixed_testing_and_added_more_examples
branch
2 times, most recently
from
5c57f78 to
c0bde1d
Compare
jcabrero
changed the title
jcabrero
force-pushed
the
feat/fixed_testing_and_added_more_examples
branch
2 times, most recently
from
cc4ff88 to
4f63716
Compare
jcabrero
force-pushed
the
feat/fixed_testing_and_added_more_examples
branch
from
4f63716 to
d0e8b89
Compare
| @@ -10,7 +10,24 @@ on: | |||
| branches: [ "*" ] | |||
|
|
|||
| jobs: | |||
| check-linting: | |||
There was a problem hiding this comment.
nice-to-have but might want to start running mypy and/or pylint at some point as well
There was a problem hiding this comment.
I agree. For the time being, I like black because it's uniform, easy to run and doesn't add a lot of complexity. Linting can be painfull on certain behaviours that we normally use.
| result = a[0] + a[1] + a[2] | ||
| result = Integer(0) | ||
| for i in range(a.shape[0]): # GET ATTR | ||
| result += a[i] # GET ITEM |
There was a problem hiding this comment.
@jcabrero Does this work nested as well? e.g., a[i][i][i]?
There was a problem hiding this comment.
Since the shape is known at compilation time, it can be done, yes.
tests/test_all.py
Outdated
| ] | ||
|
|
||
| TESTS = [("tests/nada-tests/", test) for test in TESTS] + [ | ||
| ("examples/" + test, test) for test in EXAMPLES | ||
| ("examples/" + test + "/", test) for test in EXAMPLES |
There was a problem hiding this comment.
nit but this wouldn't work on Windows --> os.path.join is probably better
There was a problem hiding this comment.
Fixed it. I may add tests for Windows, but I think nilup, nada ... do not officially support Windows besides WSL.
tests/test_all.py
Outdated
| @@ -79,7 +85,7 @@ def test_run(self, testname): | |||
| cwd = os.getcwd() | |||
| try: | |||
| # Build Nada Program | |||
There was a problem hiding this comment.
nit, I assume this comment is no longer accurate?
There was a problem hiding this comment.
Got it, thanks for pointing it out.
jcabrero
force-pushed
the
feat/fixed_testing_and_added_more_examples
branch
from
d0e8b89 to
4d5a93c
Compare
This PR does 3 things:
a) It creates a new example for broadcasting.
b) It fixes the errors where testing may not have been done because errors where not propagated.
c) It adds a linting check on the actions that can be solved by using:
black .