Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#33 change "SQL Server vNext" references to 2019 #34

Merged
merged 1 commit into from
Jul 31, 2021
Merged

#33 change "SQL Server vNext" references to 2019 #34

merged 1 commit into from
Jul 31, 2021

Conversation

BrentOzar
Copy link
Contributor

Working on #33. Didn't rename the vNext folder or edit the combined install scripts - wanted to keep the diff simple for my first PR here.

Has been tested on (remove any that don't apply):

  • SQL Server 2019

Known issue: the proc [cstore_doMaintenance] throws an error on my SQL Server 2019:

Msg 245, Level 16, State 1, Procedure cstore_doMaintenance, Line 142 [Batch Start Line 209]
Conversion failed when converting the nvarchar value 'OFF' to data type int.

It was already doing that, though - I'll create a separate issue for that and see if I can fix it.

Working on #33. Didn't rename the vNext folder or edit the combined install scripts - wanted to keep the diff simple for my first PR here.
@NikoNeugebauer NikoNeugebauer merged commit 05ef213 into NikoNeugebauer:master Jul 31, 2021
@BrentOzar
Copy link
Contributor Author

BrentOzar commented Jul 31, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants