Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "SQL Server vNext" references to 2019 #33

Open
BrentOzar opened this issue Aug 26, 2020 · 1 comment
Open

Change "SQL Server vNext" references to 2019 #33

BrentOzar opened this issue Aug 26, 2020 · 1 comment

Comments

@BrentOzar
Copy link
Contributor

Do you want to request a feature or report a bug?
Bug, but not intentional - just need to update the scripts with the new 15 version number. I'll do a pull request for it - I'm not that bright, but it's easy work, ha ha ho ho.

What is the current behavior?
The vNext folder doesn't work on SQL Server 2019 because it's checking for 14 as the version number in lines like this:

-- Ensure that we are running SQL Server vNext
if substring(@SQLServerVersion,1,CHARINDEX('.',@SQLServerVersion)-1) <> N'14'
begin
	set @errorMessage = (N'You are not running a SQL Server vNext. Your SQL Server version is ' + @SQLServerVersion);
	Throw 51000, @errorMessage, 1;
end

What is the expected behavior?
Check for version number >= 15 (just aiming for future compatibility) and say 2019 rather than vNext.

Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
Just SQL Server 2019, and hasn't worked since 2019 RTM.

NikoNeugebauer added a commit that referenced this issue Jul 31, 2021
#33 change "SQL Server vNext" references to 2019
@ZedZipDev
Copy link

What about SQL 2022 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants