Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User Disabled Security Pattern Flow #329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aserranoalliax
Copy link

Description

The plugin can't recover when user disable security pattern and try to load a new secret, the method KeyStore.getKey throw an exception and says "user changed or deleted their auth credentials", it was added a method to also remove ciphertext and IV initializationVector from app storage in order to show the message BIOMETRIC_NO_SECRET_FOUND and manage exceptions to deleteKey and storage keys from app

How did you test your changes?

I tested on a Pixel 4 emulator and also in a SM-N9600 Samsung Note 9

1.- Fix the flow when a user disable all the security, it implements after removeKey also remove the preferences store in memory and throw BIOMETRIC_NO_SECRET_FOUND until new key have been created
2.- Also split methods of create and create key for better maintance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant